| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Date: | 2026-01-05 12:11:38 |
| Message-ID: | CAA4eK1KgdCs3Z=RnmacxOBX7_jTz8nQRERBXKJYv3v-u3zWF4Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 25, 2025 at 12:31 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Dec 23, 2025 at 2:05 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > Thanks, the idea looks good now. One minor comment:
>
> Thanks for the review!
>
> > }
> > +
> > /*
> >
> > This appears to be an unnecessary addition in the patch.
>
> The added blank line is due to pgindent, so I didn't exclude it from the patch.
>
Fair enough.
> I'm not sure what the preferred practice is for handling pgindent changes
> in older branches, but in general it seems better to keep the code clean
> and pgindent-compliant even there.
>
+1.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-01-05 12:18:21 | Re: DOCS - Clarify the publication 'publish_via_partition_root' default value. |
| Previous Message | Julien Rouhaud | 2026-01-05 12:01:15 | Re: Can we remove support for standard_conforming_strings = off yet? |