| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Date: | 2015-06-10 07:34:01 |
| Message-ID: | CAA4eK1KewtxWRsqack+2JH7Tgebqw5wZH5Jh0RryAgNQEi+nGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jun 9, 2015 at 8:37 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 06/08/2015 11:19 PM, Amit Kapila wrote:
>
>>
>> I think Robert and Alvaro also seems to be inclined towards throwing
>> error for such a case, so let us do that way, but one small point is that
>> don't you think that similar code in destroy_tablespace_directories()
>> under
>> label "remove_symlink:" should use similar logic?
>>
>
>
> Yes, probably.
>
Okay, I have updated the patch to destroy_tablespace_directories() code
as well in the attached patch. I have tried to modify
remove_tablespace_symlink(), so that it can be called from
destroy_tablespace_directories(), but that is making it more complex,
especially due to the reason that destroy_tablespace_directories()
treats ENOENT as warning rather than ignoring it.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| remove_only_symlinks_during_recovery_v4.patch | application/octet-stream | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2015-06-10 13:41:59 | Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension |
| Previous Message | Fujii Masao | 2015-06-10 06:39:17 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-06-10 08:12:25 | Re: Checkpoints vs restartpoints |
| Previous Message | Fujii Masao | 2015-06-10 06:39:17 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |