| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, hlinnaka <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Date: | 2015-06-26 20:02:06 |
| Message-ID: | CA+TgmobZ17jbVVBGyF6h=q1Mt3NhLKxNHmWvCHoAoEZzYMZ1Vw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Jun 10, 2015 at 3:34 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Okay, I have updated the patch to destroy_tablespace_directories() code
> as well in the attached patch. I have tried to modify
> remove_tablespace_symlink(), so that it can be called from
> destroy_tablespace_directories(), but that is making it more complex,
> especially due to the reason that destroy_tablespace_directories()
> treats ENOENT as warning rather than ignoring it.
This pretty obviously doesn't follow style guidelines. You've got it
started with a capital letter, and there are two spaces between "a"
and "directory".
errmsg("Not a directory or symbolic link: \"%s\"",
But it looks OK otherwise, so committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-06-26 20:06:19 | pgsql: Fix grammar. |
| Previous Message | Robert Haas | 2015-06-26 20:02:02 | pgsql: Be more conservative about removing tablespace "symlinks". |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-06-26 20:02:15 | Re: Semantics of pg_file_settings view |
| Previous Message | Fabien COELHO | 2015-06-26 19:59:29 | Re: checkpointer continuous flushing |