Re: Performance degradation in commit ac1d794

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Васильев Дмитрий <d(dot)vasilyev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Performance degradation in commit ac1d794
Date: 2016-03-21 04:56:04
Message-ID: CAA4eK1K_p8ihzvRR9=Kp+c9mwSJwr41vGq+bHrQ8uCkVKkm5gw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 21, 2016 at 10:21 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:

>
>
> On March 21, 2016 5:12:38 AM GMT+01:00, Amit Kapila <
> amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> >The article pointed by you justifies that the way ResetEvent is done by
> >patch is correct. I am not sure, but you can weigh, if there is a need
> >of
> >comment so that if we want enhance this part of code (or want to write
> >something similar) in future, we don't need to rediscover this fact.
>
> I've added a reference in a comment.
>
> Did you have a chance of running the patched versions on windows?
>
>
I am planning to do it in next few hours.

> I plan to push this sometime today, so I can get on to some performance
> patches I was planning to look into committing.
>
>
have we done testing to ensure that it actually mitigate the impact of
performance degradation due to commit ac1d794. I wanted to do that, but
unfortunately the hight-end m/c on which this problem is reproducible is
down.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-03-21 05:09:18 Re: Performance degradation in commit ac1d794
Previous Message Andres Freund 2016-03-21 04:51:03 Re: Performance degradation in commit ac1d794