From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Hash Indexes |
Date: | 2016-12-01 05:43:51 |
Message-ID: | CAA4eK1KR=4nh+=F=mh=5sYCmTckXio+2PR8Qd-yTPk_8tXxMiA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Dec 1, 2016 at 2:18 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Nov 23, 2016 at 8:50 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> [ new patch ]
>
> Committed with some further cosmetic changes.
>
Thank you very much.
> I think it would be worth testing this code with very long overflow
> chains by hacking the fill factor up to 1000
>
1000 is not a valid value for fill factor. Do you intend to say 100?
or something of that
> sort, so that we get lots and lots of overflow pages before we start
> splitting. I think that might find some bugs that aren't obvious
> right now because most buckets get split before they even have a
> single overflow bucket.
>
> Also, the deadlock hazards that we talked about upthread should
> probably be documented in the README somewhere, along with why we're
> OK with accepting those hazards.
>
That makes sense. I will send a patch along that lines.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2016-12-01 06:03:14 | Re: Write Ahead Logging for Hash Indexes |
Previous Message | Pavel Stehule | 2016-12-01 04:49:56 | Re: Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default |