Re: pgsql: Prevent invalidation of newly synced replication slots.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
Date: 2026-01-28 10:46:58
Message-ID: CAA4eK1KOjv0sLKfwWddR_tLzK=Tfnsszy-PKM4xHTs7nFX3nMg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Jan 28, 2026 at 11:17 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> It is not clear to me either why the similar test like
> 040_standby_failover_slots_sync is successful and
> 046_checkpoint_logical_slot is failing. I am still thinking about it
> but thought of sharing the information I could gather by debugging.
>

It seems there is some interaction with previous test in same file
which is causing this failure as we are using the primary node from
previous test. When I tried to comment out get_changes and its
corresponding injection_point in the previous test as attached, the
entire test passed. I think if we use a freshly created primary node,
this test will pass but I wanted to spend some more time to see
how/why previous test is causing this issue?

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
comment_logical_slot_1.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2026-01-28 11:20:18 Re: pgsql: Prevent invalidation of newly synced replication slots.
Previous Message Andrey Borodin 2026-01-28 10:44:41 Re: pgsql: Prevent invalidation of newly synced replication slots.

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2026-01-28 11:12:10 Re: pg_stat_io_histogram
Previous Message Andrey Borodin 2026-01-28 10:44:41 Re: pgsql: Prevent invalidation of newly synced replication slots.