Re: pgsql: Prevent invalidation of newly synced replication slots.

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
Date: 2026-01-28 10:44:41
Message-ID: 1DF1F535-4027-4F33-98B5-7577D11053C9@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

> On 28 Jan 2026, at 10:47, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Do let me know if you could think of gathering any other information
> which can be of help here.

Interestingly, increasing timeout in pgrename() to 500 seconds fixes "Windows - Server 2022, VS 2019 - Meson & ninja ", but does not fix "Windows - Server 2022, VS 2019 - Meson & ninja".

diff --git a/src/port/dirmod.c b/src/port/dirmod.c
index 467b50d6f09..da38e37aa45 100644
--- a/src/port/dirmod.c
+++ b/src/port/dirmod.c
@@ -88,7 +88,7 @@ pgrename(const char *from, const char *to)
return -1;
#endif
- if (++loops > 100) /* time out after 10 sec */
+ if (++loops > 5000) /* time out after 10 sec */
return -1;
pg_usleep(100000); /* us */
}

Best regards, Andrey Borodin.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2026-01-28 10:46:58 Re: pgsql: Prevent invalidation of newly synced replication slots.
Previous Message Thomas Munro 2026-01-28 07:22:59 Re: pgsql: Prevent invalidation of newly synced replication slots.

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-01-28 10:46:58 Re: pgsql: Prevent invalidation of newly synced replication slots.
Previous Message Aditya Kamath 2026-01-28 10:25:41 RE: AIX support