From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Allow streaming the changes after speculative aborts. |
Date: | 2021-06-30 08:14:57 |
Message-ID: | CAA4eK1K6cWrYFdg_B8LVpMUcgSFA_fS5WUUpa65HKSW2k+3zvQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 30, 2021 at 9:55 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Wed, Jun 30, 2021 at 9:29 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Jun 29, 2021 at 12:57 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > >
> > > On Fri, Jun 25, 2021 at 12:24 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > >
> > > > Till now, we didn't allow to stream the changes in logical replication
> > > > till we receive speculative confirm or the next DML change record
> > > > after speculative inserts. The reason was that we never use to process
> > > > speculative aborts but after commit 4daa140a2f it is possible to
> > > > process them so we can allow streaming once we receive speculative
> > > > abort after speculative insertion. See attached.
> > > >
> > > > I think this is a minor improvement in the logical replication of
> > > > in-progress transactions. I have verified this for speculative aborts
> > > > and it allows streaming once we receive the spec_abort change record.
> > >
> > > Yeah, this improvement makes sense. And the patch looks fine to me.
> > >
> >
> > Thanks. Now, that the PG-15 branch is created, I think we should
> > commit this to both 15 and 14 as this is a minor change. What do you
> > think?
>
> Yeah, this is a minor improvement so can be pushed to both 15 and 14.
>
Thanks, pushed!
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2021-06-30 08:21:58 | Re: pgbench logging broken by time logic changes |
Previous Message | Amit Kapila | 2021-06-30 08:14:23 | Re: [HACKERS] logical decoding of two-phase transactions |