| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, yuanchao zhang <145zhangyc(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | Re: CREATE SUBSCRIPTION ... SERVER vs. pg_dump, etc. |
| Date: | 2026-08-04 12:53:50 |
| Message-ID: | CAA4eK1Jw3bWx+OSbEXqd7VcjEz-q8TsyfA56pJa-izDgZFLAew@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 4, 2026 at 8:29 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> > OTOH, I am also fine if you prefer to remove the retain_dead_tuples
> > check entirely from the ENABLE path and keep it in other existing
> > paths as in attached. Actually, that will slightly simplify the code
> > as well.
>
> I also preferred the approach 2. I tested on PG19 and master, and confirmed
> it could pass tests with the Jeff's reproducer. maybe_reread_subscription()
> did not take care the parameter change, but it's ok because it cannot be
> altered for the enabled subscription.
>
> The patch LGTM.
>
Thanks, I pushed the patch.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Pyhalov | 2026-08-04 13:32:22 | Re: Asynchronous MergeAppend |
| Previous Message | Alberto Piai | 2026-08-04 12:23:51 | Re: Fix ALTER COLUMN ... DROP EXPRESSSION with subpartitions |