| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, yuanchao zhang <145zhangyc(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | RE: CREATE SUBSCRIPTION ... SERVER vs. pg_dump, etc. |
| Date: | 2026-08-04 02:59:33 |
| Message-ID: | OS9PR01MB12149AF757D8D056776709EA8F5D42@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
> OTOH, I am also fine if you prefer to remove the retain_dead_tuples
> check entirely from the ENABLE path and keep it in other existing
> paths as in attached. Actually, that will slightly simplify the code
> as well.
I also preferred the approach 2. I tested on PG19 and master, and confirmed
it could pass tests with the Jeff's reproducer. maybe_reread_subscription()
did not take care the parameter change, but it's ok because it cannot be
altered for the enabled subscription.
The patch LGTM.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-08-04 03:03:25 | Re: Add a hook for handling logical decoding messages on subscribers. |
| Previous Message | kid | 2026-08-04 02:33:12 | Re: Bug in logical decoding with DDL and subtransactions |