| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | a(dot)kozhemyakin(at)postgrespro(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19556: Segmentation fault in test_decoding |
| Date: | 2026-07-23 06:50:21 |
| Message-ID: | CAA4eK1JqvU8tk4f8m=FjvQdZmzX3M_cV2uWD-P6XNt__2t=dgA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Jul 23, 2026 at 7:47 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Thank you for the patch. I like the approach the proposed patch does.
> I've made a patch for PG18+ that fixes both issues with regression
> tests. For PG17 or earlier, the patch doesn't need the changes in
> ReorderBufferPrepare() but has the same regression tests.
>
The patch LGTM. One minor point: Shall we retain the earlier comments
(We send the prepare for the concurrently aborted xacts so that later
when rollback prepared is decoded and sent, the downstream should be
able to rollback such a xact. See comments atop DecodePrepare.)? This
makes it clear why we are sending prepare for concurrent abort cases.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-07-23 11:59:03 | MERGE/SPLIT PARTITIONS issues/questions |
| Previous Message | Masahiko Sawada | 2026-07-23 02:16:46 | Re: BUG #19556: Segmentation fault in test_decoding |