| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Michael Meskes <meskes(at)postgresql(dot)org> |
| Subject: | Re: define bool in pgtypeslib_extern.h |
| Date: | 2019-10-28 06:00:14 |
| Message-ID: | CAA4eK1JfbrGNT-b=hkp5eWra0=mKM2jEA_qANugV9FqXuJeTOg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 26, 2019 at 10:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I'm inclined to think that we need to make ecpglib.h's bool-related
> definitions exactly match c.h, which will mean that it has to pull in
> <stdbool.h> on most platforms, which will mean adding a control symbol
> for that to ecpg_config.h. I do not think we should export
> HAVE_STDBOOL_H and SIZEOF_BOOL there though; probably better to have
> configure make the choice and export something named like PG_USE_STDBOOL.
>
This sounds reasonable to me, but we also might want to do something
for probes.d. To be clear, I am not immediately planning to write a
patch for this.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-10-28 06:01:31 | Re: Duplicate entries in pg_depend after REINDEX CONCURRENTLY |
| Previous Message | Kyotaro Horiguchi | 2019-10-28 05:26:39 | Re: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value |