| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: Duplicate entries in pg_depend after REINDEX CONCURRENTLY |
| Date: | 2019-10-28 06:01:31 |
| Message-ID: | 20191028055712.GB1687@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 25, 2019 at 03:43:18PM +0900, Michael Paquier wrote:
> Attached is a patch to fix the issue. As we know that the old index
> will have a definition and dependencies that match with the old one, I
> think that we should just remove any dependency records on the new
> index before moving the new set of dependencies from the old to the
> new index. The patch includes regression tests that scan pg_depend to
> check that everything remains consistent after REINDEX CONCURRENTLY.
>
> Any thoughts?
I have done more tests for this one through the day, and committed the
patch. There is still one bug pending related to partitioned indexes
where REINDEX CONCURRENTLY is cancelled after phase 4 (swap) has
committed. I am still looking more into that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-10-28 06:22:54 | Re: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value |
| Previous Message | Amit Kapila | 2019-10-28 06:00:14 | Re: define bool in pgtypeslib_extern.h |