Re: [PATCH] add concurrent_abort callback for output plugin

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] add concurrent_abort callback for output plugin
Date: 2021-04-01 03:30:09
Message-ID: CAA4eK1JUXVWL5Qo8X8rxsmdjQtrgAjy4sht3ZbLuw-y-z2SisQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 31, 2021 at 7:20 PM Markus Wanner
<markus(dot)wanner(at)enterprisedb(dot)com> wrote:
>
> On 31.03.21 15:18, Amit Kapila wrote:
> > On Wed, Mar 31, 2021 at 11:55 AM Markus Wanner
> >> The last sentences there now seems to relate to just the setting of
> >> "concurrent_abort", rather than the whole reason to invoke the
> >> prepare_cb. And the reference to the "gid" is a bit lost. Maybe:
> >>
> >> "Thus even in case of a concurrent abort, enough information is
> >> provided to the output plugin for it to properly deal with the
> >> <command>ROLLBACK PREPARED</command> once that is decoded."
> >
> > Okay, Changed the patch accordingly.
>
> That's fine with me.
>

Pushed.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-04-01 03:40:16 Re: MultiXact\SLRU buffers configuration
Previous Message Amit Kapila 2021-04-01 03:28:49 Re: [HACKERS] logical decoding of two-phase transactions