| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: row filtering for logical replication |
| Date: | 2022-01-24 03:47:09 |
| Message-ID: | CAA4eK1JLNQuEd97s6+qGaevXP2_4KkeekJf=HqCd5gAh9o2vFw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 21, 2022 at 2:56 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Thu, Jan 20, 2022 at 12:12 PM houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> (3) pgoutput_row_filter_exec_expr
> pgoutput_row_filter_exec_expr() returns false if "isnull" is true,
> otherwise (if "isnull" is false) returns the value of "ret"
> (true/false).
> So the following elog needs to be changed (Peter Smith previously
> pointed this out, but it didn't get completely changed):
>
> BEFORE:
> + elog(DEBUG3, "row filter evaluates to %s (isnull: %s)",
> + DatumGetBool(ret) ? "true" : "false",
> + isnull ? "true" : "false");
> AFTER:
> + elog(DEBUG3, "row filter evaluates to %s (isnull: %s)",
> + isnull ? "false" : DatumGetBool(ret) ? "true" : "false",
> + isnull ? "true" : "false");
>
Do you see any problem with the current? I find the current one easy
to understand.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-01-24 03:49:57 | Re: Replace uses of deprecated Python module distutils.sysconfig |
| Previous Message | Michael Paquier | 2022-01-24 03:41:49 | Re: makefiles writing to $@ should first write to $@.new |