Re: [bug fix] pg_ctl always uses the same event source

On Wed, Jul 16, 2014 at 2:11 PM, Magnus Hagander <magnus(at)hagander(dot)net>
wrote:
> On Wed, Jul 16, 2014 at 6:37 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
>
> There's also the change to throw an error if the source is already
> registered, which is potentially a bigger problem.

I think generally if the s/w is installed/registered and we try to install
it
second time without un-installing previous one, it gives some notice
indicating the same.

> Since the default
> will be the same everywhere, do we really want to throw an error when
> you install a second version, now that this is the normal state?

Allowing second version to overwrite the first can also cause problems
similar to what is reported in this thread, basically what if the second
installation/registration is removed, won't it cause the first one to loose
messages?

> There's also definitely a problem in that that codepath fires up a
> MessageBox, but it's just a function called in a DLL.

There are other paths in the same code which already fires up
MessageBox.

> It might just as
> well be called from a background service or from within an installer
> with no visible desktop, at which point the process will appear to be
> hung... I'm pretty sure you're not allowed to do that.

So in that case shouldn't we get rid of MessageBox() or provide
alternate way of logging from pgevent module.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com