| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: Change GetLastImportantRecPtr's definition? (wasSkip checkpoints, archiving on idle systems.) |
| Date: | 2017-05-05 07:34:57 |
| Message-ID: | CAA4eK1J+uraE+7zRSJQsxx_EeVO__pPxeZ+of7SVJsDe70yyZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, May 5, 2017 at 11:57 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2017-05-05 11:50:12 +0530, Amit Kapila wrote:
>> I see that EndPos can be updated in one of the cases after releasing
>> the lock (refer below code). Won't that matter?
>
> I can't see how it'd in the cases that'd matter for
> GetLastImportantRecPtr() - but it'd probably good to note it in the
> comment.
>
I think it should matter for any record which is not tagged as
XLOG_MARK_UNIMPORTANT, but maybe I am missing something in which case
comment should be fine.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-05-05 08:35:41 | pgsql: Give nicer error message when connecting to a v10 server requiri |
| Previous Message | Heikki Linnakangas | 2017-05-05 07:14:53 | pgsql: Make SCRAM salts and nonces longer. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Albe Laurenz | 2017-05-05 07:38:38 | Re: password_encryption, default and 'plain' support |
| Previous Message | Albe Laurenz | 2017-05-05 07:27:58 | Re: CTE inlining |