Re: Change GetLastImportantRecPtr's definition? (wasSkip checkpoints, archiving on idle systems.)

From: Andres Freund <andres(at)anarazel(dot)de>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: Change GetLastImportantRecPtr's definition? (wasSkip checkpoints, archiving on idle systems.)
Date: 2017-05-05 06:27:36
Message-ID: 20170505062736.2latenw7cd7tdn67@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2017-05-05 11:50:12 +0530, Amit Kapila wrote:
> I see that EndPos can be updated in one of the cases after releasing
> the lock (refer below code). Won't that matter?

I can't see how it'd in the cases that'd matter for
GetLastImportantRecPtr() - but it'd probably good to note it in the
comment.

Thanks,

Andres

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2017-05-05 07:14:52 pgsql: Misc cleanup of SCRAM code.
Previous Message Amit Kapila 2017-05-05 06:20:12 Re: Change GetLastImportantRecPtr's definition? (wasSkip checkpoints, archiving on idle systems.)

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2017-05-05 07:07:26 Re: Time based lag tracking for logical replication
Previous Message Rajkumar Raghuwanshi 2017-05-05 06:25:00 Re: Adding support for Default partition in partitioning