Re: Fix pg_publication_tables to exclude generated columns

On Mon, Jan 9, 2023 at 5:29 PM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> I noticed that there is a problem about system view pg_publication_tables when
> looking into [1]. The column "attnames" contains generated columns when no
> column list is specified, but generated columns shouldn't be included because
> they are not replicated (see send_relation_and_attrs()).
>
> I think one way to fix it is to modify pg_publication_tables query to exclude
> generated columns. But in this way, we need to bump catalog version when fixing
> it in back-branch. Another way is to modify function
> pg_get_publication_tables()'s return value to contain all supported columns if
> no column list is specified, and we don't need to change system view.
>

That sounds like a reasonable approach to fix the issue.

--
With Regards,
Amit Kapila.