From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Fix pg_publication_tables to exclude generated columns |
Date: | 2023-01-09 15:06:12 |
Message-ID: | 4091801.1673276772@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Mon, Jan 9, 2023 at 5:29 PM shiy(dot)fnst(at)fujitsu(dot)com
> <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>> I think one way to fix it is to modify pg_publication_tables query to exclude
>> generated columns. But in this way, we need to bump catalog version when fixing
>> it in back-branch. Another way is to modify function
>> pg_get_publication_tables()'s return value to contain all supported columns if
>> no column list is specified, and we don't need to change system view.
> That sounds like a reasonable approach to fix the issue.
We could just not fix it in the back branches. I'd argue that this is
as much a definition change as a bug fix, so it doesn't really feel
like something to back-patch anyway.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jelte Fennema | 2023-01-09 15:07:17 | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |
Previous Message | Maxim Orlov | 2023-01-09 15:01:37 | Re: Add SHELL_EXIT_CODE to psql |