Re: doc: update PL/pgSQL sample loop function

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: doc: update PL/pgSQL sample loop function
Date: 2019-09-11 09:50:59
Message-ID: CAA4eK1+av7Vt2+3bsODUeKiNMyui7B6WUD3YgcWynnMeOQViuQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 11, 2019 at 11:40 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
> st 11. 9. 2019 v 7:45 odesílatel Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> napsal:
>>
>> On Sun, Sep 1, 2019 at 9:09 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> >
>> > The current example shows the usage of looping in plpgsql, so as such
>> > there is no correctness issue, but OTOH there is no harm in updating
>> > the example as proposed by Ian Barwick. Does anyone else see any
>> > problem with this idea? If we agree to proceed with this update, it
>> > might be better to backpatch it for the sake of consistency though I
>> > am not sure about that.
>> >
>>
>> While checking the patch in back-branches, I noticed that it doesn't
>> get applied to 9.4 due to the way the example forms the string. I
>> have done the required changes for 9.4 as well and attached is the
>> result.
>>
>
> Is question if for this queries should not be used some from information_schema instead direct access to pg_catalog.
>
> But I looked now, and we don't see materialized views in information_schema - what is probably bug.
>

I think you got the answer of this on a related thread. Do you see
any other problems or have any concerns about this?

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2019-09-11 10:05:36 Re: doc: update PL/pgSQL sample loop function
Previous Message kuroda.hayato@fujitsu.com 2019-09-11 09:46:38 A problem presentaion about ECPG, DECLARE STATEMENT