From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
Subject: | Re: backup manifests |
Date: | 2020-03-23 11:04:28 |
Message-ID: | CAA4eK1+WyCVLZ03ZPH+POAY_NE80p+QxXDUnF10iryHj3vFjTA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 21, 2020 at 5:56 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
>
> On my CentOS, the patch gives below compilation failure:
> pg_validatebackup.c: In function ‘parse_manifest_file’:
> pg_validatebackup.c:335:19: error: assignment left-hand side might be
> a candidate for a format attribute [-Werror=suggest-attribute=format]
> context.error_cb = report_manifest_error;
>
> I have tested it on Windows and found there are multiple failures.
> The failures are as below:
>
I have started to investigate the failures.
>
> Failure Report
> ------------------------
> t/002_algorithm.pl ..... 1/19
> # Failed test 'backup ok with algorithm "none"'
> # at t/002_algorithm.pl line 33.
>
I checked the log and it was giving error:
/src/bin/pg_validatebackup/tmp_check/t_002_algorithm_master_data/backup/none
--manifest-checksum none --no-sync
\tmp_install\bin\pg_basebackup.EXE: illegal option -- manifest-checksum
It seems the option to be used should be --manifest-checksums. The
attached patch fixes this problem for me.
> t/002_algorithm.pl ..... 4/19 # Failed test 'validate backup with
> algorithm "none"'
> # at t/002_algorithm.pl line 53.
>
The error message for the above failure is:
pg_validatebackup: fatal: could not parse backup manifest: both
pathname and encoded pathname
I don't know at this stage what could cause this? Any pointers?
Attached are logs of failed runs (regression.tar.gz).
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
fix_log_002_algorithm.patch | application/octet-stream | 615 bytes |
regression.tar.gz | application/x-gzip | 5.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andy Fan | 2020-03-23 11:17:56 | Re: Index Skip Scan |
Previous Message | Daniel Gustafsson | 2020-03-23 10:23:08 | Unqualified pg_catalog casts in pg_dump |