Unqualified pg_catalog casts in pg_dump

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Unqualified pg_catalog casts in pg_dump
Date: 2020-03-23 10:23:08
Message-ID: 4AFB8CAD-3D7A-4231-AE42-3B71725A7EC1@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When looking at something different, I happened to notice that pg_dump is a bit
inconsistent in how it qualifies casts to pg_catalog entities like regclass and
oid. Most casts are qualified, but not all. Even though it functionally is
the same, being consistent is a good thing IMO and I can't see a reason not to,
so the attached patch adds qualifications (the unqualified regclass cast in the
TAP test left on purpose).

cheers ./daniel

Attachment Content-Type Size
pg_dump_casts.patch application/octet-stream 16.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-03-23 11:04:28 Re: backup manifests
Previous Message Andy Fan 2020-03-23 10:21:38 [PATCH] Keeps tracking the uniqueness with UniqueKey