| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS: Missing <structfield> tags for some SEQUENCE fields |
| Date: | 2025-11-14 03:53:20 |
| Message-ID: | CAA4eK1+NnLiFPpgcFMkas-4AOn-G0==XqO5AHHGkmO=CqU5anw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 13, 2025 at 4:46 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > On Nov 13, 2025, at 13:17, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > While reviewing the recent patches for SEQUENCE documentation I found
> > [1] a few more instances where the <structfield> tag should have been
> > used for some of the sequence fields (per the recent push [2]).
> >
>
> Good catch. LGTM. I rendered the html pages and viewed them, the pages also look good.
>
Why do we think using <structfield> tag is appropriate instead of the
current <literal> tag? The explanation of the is_called says: "Sets
the sequence object's current value, and optionally its is_called
flag.", so from "object's current value", are we deducing it is the
same as struct? Ideally, it should be used to mark up the name of a
field in a struct which is close to what we are doing here. Do we have
a similar usage at other places in the docs?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 高增琦 | 2025-11-14 04:02:30 | Compile error on the aarch64 platform: Missing asm/hwcap.h |
| Previous Message | shveta malik | 2025-11-14 03:52:54 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |