Re: Draft back-branch release notes are up

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Draft back-branch release notes are up
Date: 2026-11-09 05:37:42
Message-ID: CAA4eK1+JAcES1c5CZUM_7ESQwLi4C43Wsxxg1=fbxaCcBRP25A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 8, 2026 at 9:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> writes:
> > On Fri, Nov 06, 2026 at 02:47:52PM -0500, Tom Lane wrote:
> > + Avoid resetting a replication
> > + subscription's <literal>two_phase</literal> state to pending if it
> > + is already enabled (Zhijie Hou)
>
> > We should also mention that:
>
> > This changes behavior when slot_name is altered together with SET
> > (two_phase = true) on an ENABLED subscription. Previously the state was
> > reset to PENDING and the apply worker enabled two_phase on the replacement
> > slot. Now the state stays ENABLED and the apply worker does not touch the
> > replacement slot's two_phase property.
>
> > It's in the commit message and was added to ensure it's in the release note,
> > see [1].
>
> Hmph. I read that and I was like "so what?". Why would users need
> to know that? How likely is it that anyone would issue such a
> combined command in the first place?
>

I agree that it is less likely for users to use such a combination and
even if they use I don't think it is a big deal. We can leave
mentioning anything about such a combination.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-11-09 05:41:50 Re: Draft back-branch release notes are up
Previous Message Amit Kapila 2026-11-09 05:30:13 Re: Proposal: Conflict log history table for Logical Replication