| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-16 02:55:35 |
| Message-ID: | CAA4eK1+J9KBBFumS4LVyYWxq0Y+KaYiXqGQH-4kh_yZ4W1eVxw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 15, 2023 at 3:33 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, 15 Mar 2023 Çar, 12:31 tarihinde şunu yazdı:
>>
>> On Tue, Mar 14, 2023 at 4:32 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
>
>
>>
>> What purpose does this test serve w.r.t this patch? Before checking
>> the sync for different column orders, the patch has already changed
>> binary to false, so it doesn't seem to test the functionality of this
>> patch. Am, I missing something?
>
>
> I missed that binary has changed to false before testing column orders. I moved that test case up before changing binary to false.
> Please see v14 [1].
>
After thinking some more about this test, I don't think we need this
test as this doesn't add any value to this patch. This tests the
column orders which is well-established functionality of the apply
worker.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2023-03-16 02:57:24 | Re: Allow logical replication to copy tables in binary format |
| Previous Message | houzj.fnst@fujitsu.com | 2023-03-16 02:54:57 | RE: Allow logical replication to copy tables in binary format |