Re: Fix LOCK_TIMEOUT handling in slotsync worker

On Tue, Dec 9, 2025 at 11:23 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
> Yeah, I just searched and see similar messages:
>
> ```
> logical replication parallel apply worker for subscription \"%s\" will stop because the subscription owner's superuser privileges have been revoked
>
> logical replication worker for subscription \"%s\" will restart because the subscription owner's superuser privileges have been revoked
> ```
>
> I think the new phrase is better. Maybe “is triggered” could be “has been triggered”?
>

My AI tool says:

Both options are grammatically correct, but the nuance differs:
"will stop because promotion is triggered"
This uses the present tense ("is triggered"), which suggests the
promotion event is happening right now, concurrently with the stopping
action.
"will stop because promotion has been triggered"
This uses the present perfect tense ("has been triggered"), which
implies the promotion event already occurred and is the reason for the
upcoming stop.

In this case, because ShutDownSlotSync() will wait for the slotsync
worker to exit, so the first one ("will stop because promotion is
triggered") fits better.

--
With Regards,
Amit Kapila.