Re: Fix LOCK_TIMEOUT handling in slotsync worker

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix LOCK_TIMEOUT handling in slotsync worker
Date: 2025-12-09 06:19:46
Message-ID: 1D5571DF-AF29-4500-9EE6-CB0E7C8184A5@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Dec 9, 2025, at 14:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Dec 9, 2025 at 11:23 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>
>>
>> Yeah, I just searched and see similar messages:
>>
>> ```
>> logical replication parallel apply worker for subscription \"%s\" will stop because the subscription owner's superuser privileges have been revoked
>>
>> logical replication worker for subscription \"%s\" will restart because the subscription owner's superuser privileges have been revoked
>> ```
>>
>> I think the new phrase is better. Maybe “is triggered” could be “has been triggered”?
>>
>
> My AI tool says:
>
> Both options are grammatically correct, but the nuance differs:
> "will stop because promotion is triggered"
> This uses the present tense ("is triggered"), which suggests the
> promotion event is happening right now, concurrently with the stopping
> action.
> "will stop because promotion has been triggered"
> This uses the present perfect tense ("has been triggered"), which
> implies the promotion event already occurred and is the reason for the
> upcoming stop.
>
> In this case, because ShutDownSlotSync() will wait for the slotsync
> worker to exit, so the first one ("will stop because promotion is
> triggered") fits better.
>

Make sense. Then Zhijie’s v2 looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-12-09 06:22:15 Re: pg_dump:qemu: uncaught target signal 7 (Bus error) - core dumped
Previous Message Amit Kapila 2025-12-09 06:12:50 Re: Fix LOCK_TIMEOUT handling in slotsync worker