Re: running logical replication as the subscription owner

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Jelte Fennema <postgres(at)jeltef(dot)nl>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: running logical replication as the subscription owner
Date: 2023-05-12 03:49:03
Message-ID: CAA4eK1+CewJ=GYniRoPnLtZMa1eKo3V947Xv7ZXm=XFWgwa-Xg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 12, 2023 at 9:10 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Fri, May 12, 2023 at 1:12 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >
> > On Thu, May 11, 2023 at 7:38 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > Do we want the initial sync to also respect 'run_as_owner' option? I
> > > might be missing something but I don't see anything in the docs about
> > > initial sync interaction with this option. In the commit a2ab9c06ea,
> > > we did the permission checking during the initial sync so I thought we
> > > should do it here as well.
> >
> > It definitely should work that way. lf it doesn't, that's a bug.
>
> After some tests, it seems that the initial sync worker respects
> 'run_as_owner' during catching up but not during COPYing.
>

Yeah, I was worried during copy phase only. During catchup, the code
is common with apply worker code, so it will work.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirk Wolak 2023-05-12 04:02:34 Re: psql tests hangs
Previous Message Hayato Kuroda (Fujitsu) 2023-05-12 03:48:12 RE: Time delayed LR (WAS Re: logical replication restrictions)