From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org> |
Subject: | Re: Typo in src/backend/access/hash/README |
Date: | 2018-03-05 06:53:31 |
Message-ID: | CAA4eK1+CDXMNzF3DfDx7a8ediW26LQT9cpSBgW0nTO0bHypfuw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 5, 2018 at 9:10 AM, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> On Mon, Mar 05, 2018 at 04:30:28PM +1300, Thomas Munro wrote:
>> Hi,
>>
>> Not sure what word was missed here, but I guess "count":
>>
>> our the number of buckets stored in our cached copy of the metapage. If
>> -so, the bucket has certainly been split, because the must originally
>> +so, the bucket has certainly been split, because the count must originally
>> have been less than the number of buckets that existed at that time and
>
> I think there's a 2nd typo:
>
> |After computing the ostensibly-correct bucket number based on our cached
> |copy of the metapage, we lock the corresponding primary bucket page and
> |check whether the bucket count stored in hasho_prevblkno is greater than
> |OUR the number of buckets stored in our cached copy of the metapage. If
>
> remove "our"?
>
Both your and Thomas's proposed change looks good to me.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Rajkumar Raghuwanshi | 2018-03-05 07:13:33 | Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables |
Previous Message | Thomas Munro | 2018-03-05 06:42:40 | Re: Incorrect use of "an" and "a" in code comments and docs |