| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org> |
| Subject: | Re: Typo in src/backend/access/hash/README |
| Date: | 2018-03-05 03:40:26 |
| Message-ID: | 20180305034026.GC23634@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 05, 2018 at 04:30:28PM +1300, Thomas Munro wrote:
> Hi,
>
> Not sure what word was missed here, but I guess "count":
>
> our the number of buckets stored in our cached copy of the metapage. If
> -so, the bucket has certainly been split, because the must originally
> +so, the bucket has certainly been split, because the count must originally
> have been less than the number of buckets that existed at that time and
I think there's a 2nd typo:
|After computing the ostensibly-correct bucket number based on our cached
|copy of the metapage, we lock the corresponding primary bucket page and
|check whether the bucket count stored in hasho_prevblkno is greater than
|OUR the number of buckets stored in our cached copy of the metapage. If
remove "our"?
> --94eb2c0d4c02fe3e960566a1f43e
> Content-Type: application/octet-stream; name="somebody-accidentally-a-word.patch"
:)
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-03-05 03:51:20 | Re: Parallel Aggregates for string_agg and array_agg |
| Previous Message | Thomas Munro | 2018-03-05 03:30:28 | Typo in src/backend/access/hash/README |