Re: 1.16.1: many operations cause display tree to collapse

From: Aren Cambre <aren(at)arencambre(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Dan Halbert <halbert(at)halwitz(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgAdmin Support <pgadmin-support(at)postgresql(dot)org>
Subject: Re: 1.16.1: many operations cause display tree to collapse
Date: 2013-04-14 13:52:46
Message-ID: CAA1mBrqikwOMfLGti-w7RH7e1a4R=LbiCPCP2s+35O=nNbrcdQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Just FYI, this bug is still present in 1.16.1 (Apr 2, 2013, rev:
REL-1_16_1).

As for whether it happens when adding columns, my experience on Windows 7
is that the tree doesn't collapse when when I add columns or do other
modifications through the table's *Properties* dialog. Otherwise, it
happens whenever I complete a change that was initiated by right-clicking
on any of the nodes below the table (*Columns*, *Constraints*, etc.).

Aren

On Mon, Feb 18, 2013 at 10:19 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Mon, Feb 4, 2013 at 3:54 PM, Dan Halbert <halbert(at)halwitz(dot)org> wrote:
> >
> > On Monday, February 4, 2013 10:37am, "Dave Page" <dpage(at)pgadmin(dot)org>
> said:
> >
> > > OK, I finally managed to recreate this. It doesn't do it for me when
> > > adding columns as described, but does if I rename one. I'll have a
> > > poke around and figure out what's going on.
> >
> > > >>I can't reproduce this on Mac (the logic is the same on all
> platforms)
> > > >>- but what do you have File -> Preferences -> Browser -> UI
> > > >>Miscellaneous -> Refresh on click set to?
> > > >
> > > > I have the same issue on a Mac. It also happens when modifying
> > > > constraint and index names.
> > > > Mac OS X 10.6.8
> > > > pgAdmin3 1.16.1
> > > > UI Miscellaneous -> Refresh on click -> any setting
> >
> >
> >
> > Sorry, I never saw this query from last month. For me, I have Refresh
> set to None.
> > I think it's a bit weird you are not seeing this problem on adding
> columns, but two others of us are. Is there any way it could have to do
> with the server version? I am using 1.16.1 against PostgreSQL 9.1, running
> on Ubuntu 12.04, updated to the latest standard repo version there.
> > Dan
>
>
> Apologies for not getting further with this - it hasn't been forgotten!
>
> Akshay/Ashesh; as I mentioned in our meeting earlier today, I believe
> I've isolated the cause of this to this patch:
>
>
> http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cb5dba55dc491107e4152bd80ec496294e449934
>
> Specifically, I think the mainForm->Refresh(tblobj) call that's been
> added to dlgProperty::ShowObject() is messing up the attempt to
> re-open the tree to the original state during the existing refresh.
> Can one or both of you investigate further please?
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-support
>

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Michael Shapiro 2013-04-14 14:13:00 Re: 1.16.1: many operations cause display tree to collapse
Previous Message Guillaume Lelarge 2013-04-14 08:42:53 Re: bug with pgAdmin 1.16.1 create database?