Re: 1.16.1: many operations cause display tree to collapse

On Mon, Feb 4, 2013 at 3:54 PM, Dan Halbert <halbert(at)halwitz(dot)org> wrote:
>
> On Monday, February 4, 2013 10:37am, "Dave Page" <dpage(at)pgadmin(dot)org> said:
>
> > OK, I finally managed to recreate this. It doesn't do it for me when
> > adding columns as described, but does if I rename one. I'll have a
> > poke around and figure out what's going on.
>
> > >>I can't reproduce this on Mac (the logic is the same on all platforms)
> > >>- but what do you have File -> Preferences -> Browser -> UI
> > >>Miscellaneous -> Refresh on click set to?
> > >
> > > I have the same issue on a Mac. It also happens when modifying
> > > constraint and index names.
> > > Mac OS X 10.6.8
> > > pgAdmin3 1.16.1
> > > UI Miscellaneous -> Refresh on click -> any setting
>
>
>
> Sorry, I never saw this query from last month. For me, I have Refresh set to None.
> I think it's a bit weird you are not seeing this problem on adding columns, but two others of us are. Is there any way it could have to do with the server version? I am using 1.16.1 against PostgreSQL 9.1, running on Ubuntu 12.04, updated to the latest standard repo version there.
> Dan

Apologies for not getting further with this - it hasn't been forgotten!

Akshay/Ashesh; as I mentioned in our meeting earlier today, I believe
I've isolated the cause of this to this patch:

http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cb5dba55dc491107e4152bd80ec496294e449934

Specifically, I think the mainForm->Refresh(tblobj) call that's been
added to dlgProperty::ShowObject() is messing up the attempt to
re-open the tree to the original state during the existing refresh.
Can one or both of you investigate further please?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company