| From: | Thom Brown <thom(at)linux(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Prevent duplicate attributes |
| Date: | 2011-07-12 09:55:25 |
| Message-ID: | CAA-aLv7QCjPavOFesZ2mE9wCizZ5CPchtFeZFhaD1uygPd8iwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On 12 July 2011 10:53, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown <thom(at)linux(dot)com> wrote:
>> Hi (yes, me... again),
>>
>> Tiny patch attached to prevent adding attributes with a duplicate name
>> to a type. It seems previous versions prevented this, but must have
>> been allowed in a commit since the last release.
>
> For consistency with the other checks on the dialogue, this should
> cause the "Add" button to be disabled, not make it silently fail. That
> should almost certainly be done in dlgType::CheckChange().
Yes, you're right.
--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2011-07-12 09:59:14 | Re: New key shortcuts for query window |
| Previous Message | Dave Page | 2011-07-12 09:53:19 | Re: Prevent duplicate attributes |