| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Thom Brown <thom(at)linux(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Prevent duplicate attributes |
| Date: | 2011-07-12 10:11:36 |
| Message-ID: | 1310465498.1993.39.camel@laptop |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote:
> On 12 July 2011 10:53, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> > On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> >> Hi (yes, me... again),
> >>
> >> Tiny patch attached to prevent adding attributes with a duplicate name
> >> to a type. It seems previous versions prevented this, but must have
> >> been allowed in a commit since the last release.
> >
> > For consistency with the other checks on the dialogue, this should
> > cause the "Add" button to be disabled, not make it silently fail. That
> > should almost certainly be done in dlgType::CheckChange().
>
> Yes, you're right.
>
Does this patch need to be applied after the "overhaul of type
attributes" one?
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2011-07-12 10:17:56 | Re: Prevent duplicate attributes |
| Previous Message | Dave Page | 2011-07-12 10:11:06 | Re: New key shortcuts for query window |