Re: Remove references to pre-11 versions

From: Thom Brown <thom(at)linux(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove references to pre-11 versions
Date: 2023-04-21 11:53:14
Message-ID: CAA-aLv7+WXAKcSEBGZ138Y5F+TExa8gLv+gPPavXV3kCEo-0pw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 19 Apr 2023 at 14:58, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Thom Brown <thom(at)linux(dot)com> writes:
> > I've attached a patch that removes some now redundant messaging about
> > unsupported versions.
>
> If we want to make that a policy, I think a lot more could be done
> --- I remember noticing a documentation comment about some 8.x
> version just recently.
>
> However, "out of support" is a lot different from "nobody has any
> code written for that version anymore". So I'd be inclined to keep
> the first hunk in your patch, the one explaining the regexp_matches-
> in-a-subselect trick. People will be trying to puzzle out why
> somebody did it like that for years to come.
>
> I agree with simplifying the other two spots.

Fair enough. I've updated the patch. However, feel free to ignore if
this marks the thin edge of the wedge.

Thom

Attachment Content-Type Size
old_version_removal_v2.patch application/octet-stream 2.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2023-04-21 12:09:54 Re: Improve list manipulation in several places
Previous Message Ajit Awekar 2023-04-21 11:25:20 Re: Memory leak in CachememoryContext