| From: | David Christensen <david(dot)christensen(at)crunchydata(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] add relation and block-level filtering to pg_waldump |
| Date: | 2022-03-24 12:43:02 |
| Message-ID: | CA702020-B3F9-4597-86F7-EFB1CB7D6E42@crunchydata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 24, 2022, at 6:43 AM, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Fri, Mar 25, 2022 at 12:26 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>>> On Fri, Mar 25, 2022 at 12:01 AM Peter Eisentraut
>>> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>>> Or even: Why are we exposing fork *numbers* in the user interface?
>>> Even low-level tools such as pageinspect use fork *names* in their
>>> interface.
>>
>> I wondered about that but thought it seemed OK for such a low level
>> tool. It's a fair point though, especially if other low level tools
>> are doing that. Here's a patch to change it.
>
> Oh, and there's already a name lookup function to use for this.
+1 on the semantic names.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-03-24 12:44:51 | Re: TAP output format in pg_regress |
| Previous Message | Simon Riggs | 2022-03-24 12:12:56 | Re: Documenting when to retry on serialization failure |