| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | David Christensen <david(dot)christensen(at)crunchydata(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] add relation and block-level filtering to pg_waldump |
| Date: | 2022-03-24 11:42:50 |
| Message-ID: | CA+hUKGL+0PrQmEnnHidi1Vc-5f8Bqo4bpHAbuBk778c1k8Aiow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 25, 2022 at 12:26 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Fri, Mar 25, 2022 at 12:01 AM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> > Or even: Why are we exposing fork *numbers* in the user interface?
> > Even low-level tools such as pageinspect use fork *names* in their
> > interface.
>
> I wondered about that but thought it seemed OK for such a low level
> tool. It's a fair point though, especially if other low level tools
> are doing that. Here's a patch to change it.
Oh, and there's already a name lookup function to use for this.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Use-fork-names-not-numbers-in-pg_waldump-option.patch | text/x-patch | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-03-24 12:09:26 | Re: turn fastgetattr and heap_getattr to inline functions |
| Previous Message | Jesper Pedersen | 2022-03-24 11:39:31 | Re: Index Skip Scan (new UniqueKeys) |