Re: Pluggable Storage - Andres's take

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Pluggable Storage - Andres's take
Date: 2019-01-15 06:58:55
Message-ID: CA+q6zcWKMVop9DBd=cui+sPLMSqfVZyh+GrF=s-5G9rzW90FXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On Mon, Jan 14, 2019 at 2:07 PM Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
>
> createPQExpBuffer() should be moved after the below statement, so that
> it does not leak memory

Thanks for noticing, fixed.

> So how about bumping up the archive version and doing these checks ?

Yeah, you're right, I've added this check.

Attachment Content-Type Size
pg_dump_access_method_v3.patch application/octet-stream 27.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2019-01-15 06:59:15 Re: [HACKERS] Block level parallel vacuum
Previous Message Amit Langote 2019-01-15 06:31:24 Re: using expression syntax for partition bounds