| From: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: split func.sgml to separated individual sgml files |
| Date: | 2025-09-01 15:44:01 |
| Message-ID: | CA+v5N41e5QGe0qY1jTdQi7B7z54+AEP+N9oc0z=wXFEVox6onw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1 Sep 2025, at 4:35 PM, Euler Taveira <euler(at)eulerto(dot)com> wrote:
On Mon, Sep 1, 2025, at 7:35 AM, Florents Tselai wrote:
While working on this https://commitfest.postgresql.org/patch/6020/
I discovered that when changing for func/func-aggregate.sgml, the HTML
wasn’t marked for update.
IIUC the doc/Makefile should be updated as attached, right ?
Good catch.
However, your patch doesn't fix all issues. The check target (check-tabs and
check-nbsp) is broken; these targets should also include the func files.
Ah, you’re right, but then again, I’d expect ALL_SGML to be used
consistently, but it isn't and I didn't check.
v3 does that.
Note that GENERATED_SGML where'te included in these two targets but I think
there's no harm in checking them too.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-The-commit-4e23c9ef65a-forgot-to-add-dependencies.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2025-09-01 18:35:56 | Re: Orphan page in _bt_split |
| Previous Message | Antonin Houska | 2025-09-01 15:30:18 | Re: Adding REPACK [concurrently] |