| From: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
|---|---|
| To: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |
| Date: | 2026-01-31 16:23:27 |
| Message-ID: | CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 31, 2026 at 4:44 PM David E. Wheeler <david(at)justatheory(dot)com>
wrote:
> On Jan 4, 2026, at 15:51, David E. Wheeler <david(at)justatheory(dot)com> wrote:
>
> > Updated and rebased patch attached.
>
I think your attachment was left behind. Attaching it myself (that's v17,
right? ) checked out from your PR
New rebase on 6918434. See also the PR[0].
> The Commitfest app still shows this patch as “Needs review”[1]. It has had
> a number of reviews, most recently from jian. Any objection to changing it
> to “Ready for Committer”?
With the refactoring you’ve done across the parser and executor,
I’m already tempted to slip in a few more string methods - but I think we
should leave that for a future iteration.
Functionally, it’d just mean adding another branch in
executeStringInternalMethod,
and I’d rather keep this patch focused.
At this point, I’d say it’s ready for committer review.
That said, I do expect someone to raise (again) the question of
how we want to handle potential future conflicts with the SQL/JSON
standard.
That’s a broader design topic, and it’s going to come up every time we
extend the JSONPath language.
And yes, I’m obviously biased here - I already have two other patches in
the same spirit queued up, namely
https://commitfest.postgresql.org/patch/6429/
https://commitfest.postgresql.org/patch/6436/
| Attachment | Content-Type | Size |
|---|---|---|
| v17-0001-Rename-jsonpath-method-arg-tokens.patch | application/octet-stream | 3.9 KB |
| v17-0002-Add-additional-jsonpath-string-methods.patch | application/octet-stream | 51.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2026-01-31 16:31:08 | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |
| Previous Message | Nathan Bossart | 2026-01-31 16:21:49 | Re: pg_dumpall --roles-only interact with other options |