| From: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
|---|---|
| To: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |
| Date: | 2026-01-31 16:31:08 |
| Message-ID: | 931F201B-FF38-486E-BDEE-DF9692A01E1D@justatheory.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Jan 31, 2026, at 11:23, Florents Tselai <florents(dot)tselai(at)gmail(dot)com> wrote:
> I think your attachment was left behind. Attaching it myself (that's v17, right? ) checked out from your PR
Bah! Yes, thank you.
> With the refactoring you’ve done across the parser and executor,
> I’m already tempted to slip in a few more string methods - but I think we should leave that for a future iteration.
> Functionally, it’d just mean adding another branch in executeStringInternalMethod,
> and I’d rather keep this patch focused.
Agreed.
> At this point, I’d say it’s ready for committer review.
>
> That said, I do expect someone to raise (again) the question of
> how we want to handle potential future conflicts with the SQL/JSON standard.
> That’s a broader design topic, and it’s going to come up every time we extend the JSONPath language.
Yup, continual challenge, part of the deal IME.
> And yes, I’m obviously biased here - I already have two other patches in the same spirit queued up, namely
> https://commitfest.postgresql.org/patch/6429/
> https://commitfest.postgresql.org/patch/6436/
Ha! Message received, I’ll try to find some time to look at them.
D
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2026-01-31 16:32:00 | Re: ABI Compliance Checker GSoC Project |
| Previous Message | Florents Tselai | 2026-01-31 16:23:27 | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |