| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | michael(dot)banck(at)credativ(dot)de |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Online verification of checksums |
| Date: | 2018-12-01 11:47:13 |
| Message-ID: | CA+q6zcXaw+firw_z-XuOeTfz0OQKoRN3t5LsCV13YP-0-DEoTQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Wed, Nov 21, 2018 at 1:38 PM Michael Banck <michael(dot)banck(at)credativ(dot)de> wrote:
>
> Hi,
>
> On Tue, Oct 30, 2018 at 06:22:52PM +0100, Fabien COELHO wrote:
> > >I am not convinced we need to differentiate further between online and
> > >offline operation, can you explain in more detail which other
> > >differences are ok in online mode and why?
> >
> > For instance the "file/directory was removed" do not look okay at all when
> > offline, even if unlikely. Moreover, the checks hides the error message and
> > is fully silent in this case, while it was not beforehand on the same error
> > when offline.
>
> OK, I kinda see the point here and added that.
Hi,
Just for the information, looks like part of this patch (or at least some
similar code), related to the tests in 002_actions.pl, was committed recently
in 5c99513975, so there are minor conflicts with the master.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2018-12-01 12:11:01 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |
| Previous Message | Dmitry Dolgov | 2018-12-01 11:23:01 | Re: cursors with prepared statements |