From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Cache lookup errors with functions manipulation object addresses |
Date: | 2019-09-23 19:15:24 |
Message-ID: | CA+q6zcXUTUjUXmG-pKKDBEvF_+2xFmkvTXL-jE_U2b-MWRD7ag@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Tue, Jul 2, 2019 at 9:28 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Feb 21, 2019 at 04:40:13PM +0900, Michael Paquier wrote:
> > Rebased version fixing some conflicts with HEAD.
>
> And rebased version for this stuff on HEAD (66c5bd3), giving visibly
> v16.
Thanks for the patch! I couldn't check it in action, since looks like it
doesn't apply anymore [1] (although after a quick check I'm not entirely sure
why). Nevertheless I have a few short commentaries:
v16-0001-Add-flag-to-format_type_extended-to-enforce-NULL.patch
- if (type_oid == InvalidOid && (flags & FORMAT_TYPE_ALLOW_INVALID) != 0)
- return pstrdup("-");
+ if (type_oid == InvalidOid)
+ {
+ if ((flags & FORMAT_TYPE_FORCE_NULL) != 0)
+ return NULL;
+ else if ((flags & FORMAT_TYPE_ALLOW_INVALID) != 0)
+ return pstrdup("-");
+ }
Here and in format_operator_extened commentary says
* Returns a palloc'd string.
but now it's possible to return NULL, so I guess comments need to be adjusted,
right?
v16-0003-Eliminate-user-visible-cache-lookup-errors-for-o.patch
- appendStringInfo(&buffer, _("operator %s"),
- format_operator(object->objectId));
- break;
+ {
+ char *oprname = format_operator_extended(object->objectId,
+ FORMAT_PROC_FORCE_NULL);
Shouldn't it be FORMAT_OPERATOR_FORCE_NULL here?
I'll continue reviewing the last patch in more details.
From | Date | Subject | |
---|---|---|---|
Next Message | legrand legrand | 2019-09-23 19:25:51 | Re: Proposal: Better query optimization for "NOT IN" clause |
Previous Message | Steven Pousty | 2019-09-23 19:10:28 | Re: JSONPATH documentation |