Re: libpq compression

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: libpq compression
Date: 2019-02-13 14:52:13
Message-ID: CA+q6zcW-EdonARyWjEJ9FhikOAn3i-uFAjv2mMM1zwO824XqOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Wed, Feb 13, 2019 at 3:46 PM Konstantin Knizhnik
> <k(dot)knizhnik(at)postgrespro(dot)ru> wrote:
>
> Moreover, please notice that your implementation is still passing functions
> tx/rx functions to stream constructor and so zpq_read is still able to read
> data itself. So I do not understand which problem you have solved by
> replacing zpq_read with pair of zpq_read_drain+zpq_read.

Nope, I've removed the call of these functions from zlib_read/write, just
forgot to remove the initialization part.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2019-02-13 14:54:10 Re: libpq compression
Previous Message Konstantin Knizhnik 2019-02-13 14:46:00 Re: libpq compression