| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru> |
| Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: libpq compression |
| Date: | 2019-02-13 14:54:10 |
| Message-ID: | CA+q6zcU4FCCt_V=v3yJXmr-xh-i_EgCVVg5W+ys9oHNmZSr2aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Wed, Feb 13, 2019 at 3:52 PM Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
>
> > On Wed, Feb 13, 2019 at 3:46 PM Konstantin Knizhnik
> > <k(dot)knizhnik(at)postgrespro(dot)ru> wrote:
> >
> > Moreover, please notice that your implementation is still passing functions
> > tx/rx functions to stream constructor and so zpq_read is still able to read
> > data itself. So I do not understand which problem you have solved by
> > replacing zpq_read with pair of zpq_read_drain+zpq_read.
>
> Nope, I've removed the call of these functions from zlib_read/write, just
> forgot to remove the initialization part.
Oh, I see the source of confusion. Due to lack of time I've implemented my
changes only for zlib part, sorry that I didn't mention that before.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-13 14:57:27 | Re: WAL insert delay settings |
| Previous Message | Dmitry Dolgov | 2019-02-13 14:52:13 | Re: libpq compression |