Re: AIX support - alignment issues

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: AIX support - alignment issues
Date: 2022-07-06 04:52:56
Message-ID: CA+hUKGLkWWkn3m9X_=0uek20QJUnz3bf85dVAHEcu7fWE+aXmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 6, 2022 at 3:26 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2022-07-06 14:21:50 +1200, Thomas Munro wrote:
> > - * Notice that this means that we actually clear the word to set
> > - * the lock and set the word to clear the lock. This is the
> > - * opposite behavior from the SPARC LDSTUB instruction. For some
> > - * reason everything that H-P does is rather baroque...

> Are these comments retained elsewhere? It's confusing enough that I think we
> should make sure they're somewhere until we remove hppa support...

OK, I moved them into s_lock.h where the remaining asm lives.

> > -#if defined(__ia64__) || defined(__ia64)
> > -/*
> > - * Intel Itanium, gcc or Intel's compiler.
>
> Hm. Personally I'd do HPUX removal separately from IA64 removal.

OK, split.

Attachment Content-Type Size
v3-0001-Remove-HP-UX-support.patch application/x-patch 38.8 KB
v3-0002-Remove-HP-Intel-Itanium-support.patch application/x-patch 10.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2022-07-06 05:10:20 Re: [PATCH] Optimize json_lex_string by batching character copying
Previous Message Peter Smith 2022-07-06 04:38:13 Re: Re-order "disable_on_error" in tab-complete COMPLETE_WITH