Re: LDAP check flapping on crake due to race

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: LDAP check flapping on crake due to race
Date: 2020-08-03 00:12:57
Message-ID: CA+hUKGLeQFnvweFm=5+Gpp1viXei9q_P62thU8rfsbiGojmZVQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 3, 2020 at 4:09 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I'm inclined to suggest that the LDAP test's test_access could use
> an empty stdin and pass "-c 'SELECT 1'" as a command line option
> instead. (Maybe that's exactly what you meant, but I'm not sure.)

Good idea. Here's a patch like that.

> I've not been able to duplicate this locally, so I have no idea if
> that'd really fix it.

Me neither -- I guess someone who enjoys perl could hack IPC::Run to
take a short nap at the right moment.

Attachment Content-Type Size
0001-Fix-rare-failure-in-LDAP-tests.patch application/x-patch 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2020-08-03 00:18:08 dblnk_is_busy returns 1 for dead connecitons
Previous Message David Rowley 2020-08-02 23:42:00 Re: Comment simplehash/dynahash trade-offs