Re: LDAP check flapping on crake due to race

From: Noah Misch <noah(at)leadboat(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: LDAP check flapping on crake due to race
Date: 2020-08-03 00:28:57
Message-ID: 20200803002857.GC43516@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 03, 2020 at 12:12:57PM +1200, Thomas Munro wrote:
> On Mon, Aug 3, 2020 at 4:09 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I'm inclined to suggest that the LDAP test's test_access could use
> > an empty stdin and pass "-c 'SELECT 1'" as a command line option
> > instead. (Maybe that's exactly what you meant, but I'm not sure.)
>
> Good idea. Here's a patch like that.

While I had meant a different approach, this is superior.

> > I've not been able to duplicate this locally, so I have no idea if
> > that'd really fix it.
>
> Me neither -- I guess someone who enjoys perl could hack IPC::Run to
> take a short nap at the right moment.

Not essential to reproduce first, I think.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2020-08-03 00:52:03 Re: LDAP check flapping on crake due to race
Previous Message Thomas Munro 2020-08-03 00:24:55 Re: Comment simplehash/dynahash trade-offs