Re: --with-llvm on 32-bit platforms?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dmitry Mityugov <d(dot)mityugov(at)postgrespro(dot)ru>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: --with-llvm on 32-bit platforms?
Date: 2025-09-16 13:34:45
Message-ID: CA+hUKGLaNj7f47hTF5qLAmCYzz5yoR8PEz2OR_KNde2Jn6tLfg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 16, 2025 at 12:51 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Tue, Sep 16, 2025 at 12:05 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > > Hmm. We use TypeSizeT in generated IR for Datum, which is obviously
> > > incorrect in this configuration.
> >
> > Oh! Yeah, that is surely broken now.

This patch seems to work OK here. The deform code is a little tricky
as you have to think carefully about which places need TypeDatum and
which need TypeSizeT in llvmjit_deform.c, since the v_offp variable
really is size_t. Tested on Debian 13 with i386 packages installed.

More changes would be needed if Datum is changed into a struct.

Attachment Content-Type Size
v1-0001-jit-Fix-type-used-for-Datum-values-in-LLVM-IR.patch application/x-patch 25.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-09-16 13:45:10 Re: --with-llvm on 32-bit platforms?
Previous Message torikoshia 2025-09-16 13:30:31 Re: RFC: Logging plan of the running query